Skip to content

Conversation

@visheshrace
Copy link
Contributor

@visheshrace visheshrace commented Feb 5, 2025

Update RACE testnet config file for fault-proof upgrade

@visheshrace visheshrace requested a review from a team as a code owner February 5, 2025 12:25
@visheshrace
Copy link
Contributor Author

Hi @sbvegan, could you please review this latest pull request?
I have followed the optimism mainnet config file.

@sbvegan
Copy link
Collaborator

sbvegan commented Feb 11, 2025

@visheshrace can you please run just codegen and see if this fixes the failing ci checks?

@visheshrace
Copy link
Contributor Author

@sbvegan I encountered an error while running just codegen

[NOTOK] application error: error generating code: error generating addresses file: failed to write addresses file: failed to rename temp file: rename /tmp/atomic1837045125 invalid cross-device link
This was caused by temporary files being written to /tmp, leading to a cross-device link issue.
To resolve this, I set the TMPDIR environment variable and created a dedicated temp directory:

export TMPDIR=/home/visheshgupta/tmp mkdir -p $TMPDIR

After this, running just codegen passes all the checks

@visheshrace
Copy link
Contributor Author

visheshrace commented Feb 12, 2025

@sbvegan I encountered an error while running just codegen

[NOTOK] application error: error generating code: error generating addresses file: failed to write addresses file: failed to rename temp file: rename /tmp/atomic1837045125 invalid cross-device link This was caused by temporary files being written to /tmp, leading to a cross-device link issue. To resolve this, I set the TMPDIR environment variable and created a dedicated temp directory:

export TMPDIR=/home/visheshgupta/tmp mkdir -p $TMPDIR

After this, running just codegen passes all the checks

this is the output
cd ops && go run ./cmd/codegen/main.go
[ OK] generated addresses file
[ OK] generated JSON chain list
[ OK] generated TOML chain list
[ OK] generated chains readme

@visheshrace
Copy link
Contributor Author

Added CHAINS.md to the PR. check-codegen test passed successfully.


[addresses]
AddressManager = "0x1B573Db1000eA419B6dE8eB482C6d394179Bd1A3"
AddressManager = "0x1B573Db1000eA419B6dE8eB482C6d394179Bd1A3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@visheshrace can you adjust the formatting here? The trailing space after AddressManager makes a CI check fail

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wazabie I have adjust the formatting. But still 3 checks are failing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wazabie I have adjust the formatting. But still 3 checks are failing

After running just codegen command and include Chains.md to the PR one more check pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants